Apache9 commented on PR #7665: URL: https://github.com/apache/hbase/pull/7665#issuecomment-3816907563
OK, got it. Seems reasonable. So what about this: 1. We add a setRequestAttributeFactory method, as you proposed in this PR, but take a Supplier<Map<String, byte[]>> as parameter. 2. Introduce a FixedRequestAttributeFactory class, which always return the same request attribute map, as the default implementation. Also use Builder pattern for creating this factory class. 3. Deprecated the old addRequestAttribute method in AsyncTableBuilder, let users use the new setRequestAttributeFactory method. But when users call the old addRequestAttribute method, we internally use FixedRequestAttributeFactory's Builder to create a FixedRequestAttributeFactory in the end. 4. Do the same for sync client interfaces. WDYT? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
