Apache9 commented on PR #7665: URL: https://github.com/apache/hbase/pull/7665#issuecomment-3822349454
> What do you think of also deprecating `AsyncTable#getRequestAttributes()` without a replacement, if the behavior of it is no longer well defined (i.e. the return value could change based on which thread it is called from)? I like your suggestion to merge the two request attribute setters on AsyncTableBuilder into one, but the complication I see is that now getRequestAttributes() no longer has any static set of attributes to return. I'm not sure why `getRequestAttributes()` would be useful to anyone, but nevertheless it might be harder for a user to migrate away from using that. We can just call request attribute factory's method to get the request attribute for this method? And we can add more javadoc to mention that, since now we allow dynamic request attribute when requesting, the return value may not be the same when you implement a dynamic request attribute factory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
