anmolnar commented on code in PR #7857:
URL: https://github.com/apache/hbase/pull/7857#discussion_r2924710242
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/ActiveClusterSuffix.java:
##########
@@ -31,18 +34,40 @@
*/
@InterfaceAudience.Private
public class ActiveClusterSuffix {
- private final String active_cluster_suffix;
+ private final String cluster_id;
+ private final String suffix;
/**
* New ActiveClusterSuffix.
*/
- public ActiveClusterSuffix(final String cs) {
- this.active_cluster_suffix = cs;
+ public ActiveClusterSuffix(final String cs, final String suffix) {
+ this.cluster_id = cs;
+ this.suffix = suffix;
}
- public String getActiveClusterSuffix() {
- return active_cluster_suffix;
+ public ActiveClusterSuffix(final String input) {
Review Comment:
I think we should implement regex validation somewhere to make sure that
suffix only contains valid characters. We can do this in a separate ticket.
Something like: `^[a-zA-Z0-9]`
What we should do in this ticket though is to add unit test to cover the
split logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
