sharmaar12 commented on code in PR #7922:
URL: https://github.com/apache/hbase/pull/7922#discussion_r2932134953
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AbstractReadOnlyController.java:
##########
@@ -84,13 +85,14 @@ public static void manageActiveClusterIdFile(boolean
readOnlyEnabled, MasterFile
"Failed to delete active cluster file: {}. "
+ "Read-only flag will be updated, but file system state is
inconsistent.",
activeClusterFile, e);
+ } catch (DeserializationException e) {
+ LOG.error("Failed to deserialize ActiveClusterSuffix from file {}",
activeClusterFile, e);
Review Comment:
@anmolnar I believe we just log the error for any of these exception is
because the cluster is read only which means it is expected to delete the file
if it exists and cluster is the owner of that file, but if the file does not
exists or it is not the owner then we can safely ignore it, because for
read-only we are not mutating any data so safe to start the cluster.
Similarly I think if we can't deserialize it then deletion will not happen,
but cluster can start in read-only mode. Anyways this case needs manual
intervention because of cluster ID file corruption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
