liuxiaocs7 commented on code in PR #8046:
URL: https://github.com/apache/hbase/pull/8046#discussion_r3068027993
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobStoreCompaction.java:
##########
@@ -123,10 +115,14 @@ public TestMobStoreCompaction(Boolean useFileBasedSFT) {
this.useFileBasedSFT = useFileBasedSFT;
}
- @Parameterized.Parameters
- public static Collection<Boolean> data() {
+ public static Stream<Arguments> parameters() {
Boolean[] data = { false, true };
- return Arrays.asList(data);
+ return Arrays.asList(data).stream().map(Arguments::of);
+ }
+
+ @BeforeEach
+ public void setUp(TestInfo testInfo) {
+ testMethodName = testInfo.getTestMethod().get().getName();
}
Review Comment:
`testInfo.getTestMethod().get().getName() + testInfo.getDisplayName()`
returns `testSmallerValue1: useFileBasedSFT=false`
use `testInfo.getTestMethod().get().getName() +
testInfo.getDisplayName().replaceAll("[:= ]", "_").replaceAll("_+",
"_").trim()`, returns `testSmallerValue1_useFileBasedSFT_false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
