Copilot commented on code in PR #8121:
URL: https://github.com/apache/hbase/pull/8121#discussion_r3136107519
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSecureNettyRpcServer.java:
##########
@@ -78,12 +80,12 @@ public void tearDown() throws Exception {
}
Review Comment:
`tearDown()` unconditionally calls `KEYTAB_FILE.delete()`. If `setup()`
fails part-way, JUnit may still invoke `@AfterEach`, and this will throw a
`NullPointerException` that masks the real failure. Guard with a null check
(and ideally check `exists()`/handle a failed delete) similar to how other
secure RPC tests handle keytab cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
