PDavid commented on code in PR #8157:
URL: https://github.com/apache/hbase/pull/8157#discussion_r3153793146
##########
hbase-website/public/sitemap.xml:
##########
Review Comment:
As I understand we have a script to generate this file. Can I ask why is
this committed? I guess new builds will generate new version of this file with
different timestamps so we will have local modifications on this file. 🤔
Should we rather git ignore this file instead?
##########
hbase-website/package.json:
##########
@@ -75,6 +76,7 @@
"remark-gfm": "^4.0.1",
"remark-math": "^6.0.0",
"scroll-into-view-if-needed": "^3.1.0",
+ "sitemap": "^9.0.1",
Review Comment:
sitemap is added to `dependencies` rather than `devDependencies`. Since it's
only used in the build script (not at runtime), I guess it should be a dev
dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
