yuriipalam commented on code in PR #8157: URL: https://github.com/apache/hbase/pull/8157#discussion_r3281907192
########## hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/upgrading/version-number.mdx: ########## @@ -149,6 +154,4 @@ When we say two HBase versions are compatible, we mean that the versions are wir [^2]: See http://docs.oracle.com/javase/specs/jls/se8/html/jls-13.html. -[^3]: Note that this indicates what could break, not that it will break. We will/should add specifics in our release notes. Review Comment: Because this footnote was added to the heading, what leads to a nested link problem. In docs frameworks headings are links because they are anchors, same for footnotes. So we had something like ```html <a> <h4>Heading...</h4> <a>^3</a> <a> ``` It's wrong HTML structure which leads to a hydration error. Due to the async nature of the e2e tests, we couldn't reliably catch this issue before. It might be a new task to work on for me actually, to make it more deterministic. So, I just moved the footnote right under the heading since it's the only place where it's used. This way we fix the broken structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
