Apache9 commented on code in PR #8353:
URL: https://github.com/apache/hbase/pull/8353#discussion_r3408035312
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java:
##########
@@ -97,9 +96,9 @@ public BlockCacheKey(String hfileName, String cfName, String
regionName, long of
this.offset = offset;
this.blockType = blockType;
// Use string pool for file, region and cf values
- this.hfileName = HFILE_NAME_POOL.intern(hfileName);
- this.regionName = (regionName != null) ?
REGION_NAME_POOL.intern(regionName) : null;
- this.cfName = (cfName != null) ? CF_NAME_POOL.intern(cfName) : null;
+ this.hfileName = hfileName;
Review Comment:
If we do not do intern here, why we still put the above 3 string pools in
this class?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java:
##########
@@ -115,7 +114,7 @@ public BlockCacheKey(String hfileName, String cfName,
String regionName, long of
public BlockCacheKey(Path hfilePath, long offset, boolean isPrimaryReplica,
BlockType blockType) {
this(hfilePath.getName(), hfilePath.getParent().getName(),
hfilePath.getParent().getParent().getName(), offset, isPrimaryReplica,
blockType,
- HFileArchiveUtil.isHFileArchived(hfilePath));
Review Comment:
Why here we can use false directly?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java:
##########
@@ -17,6 +17,7 @@
*/
package org.apache.hadoop.hbase.io.hfile;
+import org.apache.commons.lang3.mutable.MutableBoolean;
Review Comment:
Where do we use this import?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
