Apache9 commented on code in PR #8353:
URL: https://github.com/apache/hbase/pull/8353#discussion_r3414209683
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java:
##########
@@ -97,9 +96,9 @@ public BlockCacheKey(String hfileName, String cfName, String
regionName, long of
this.offset = offset;
this.blockType = blockType;
// Use string pool for file, region and cf values
- this.hfileName = HFILE_NAME_POOL.intern(hfileName);
- this.regionName = (regionName != null) ?
REGION_NAME_POOL.intern(regionName) : null;
- this.cfName = (cfName != null) ? CF_NAME_POOL.intern(cfName) : null;
+ this.hfileName = hfileName;
Review Comment:
Why not introduce a new class to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
