[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450832#comment-13450832
]
Ted Yu commented on HBASE-6698:
-------------------------------
Latest patch is much cleaner.
Please remind me what the following change is for:
{code}
- Delete delete = new Delete();
+ Delete delete = new Delete(new byte[0]);
{code}
Please rename the variable below to reflect the nature of this change:
{code}
+ putsAndLocks[0] = new Pair<Mutation, Integer>(mutation, lid);
{code}
>From https://builds.apache.org/job/PreCommit-HBASE-Build/2814/console, it was
>clear TestReplication hung.
> Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
> ------------------------------------------------------------------
>
> Key: HBASE-6698
> URL: https://issues.apache.org/jira/browse/HBASE-6698
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.96.0
>
> Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch,
> HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698.patch
>
>
> Currently the checkAndPut and checkAndDelete api internally calls the
> internalPut and internalDelete. May be we can just call doMiniBatchMutation
> only. This will help in future like if we have some hooks and the CP
> handles certain cases in the doMiniBatchMutation the same can be done while
> doing a put thro checkAndPut or while doing a delete thro checkAndDelete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
