[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452148#comment-13452148
]
ramkrishna.s.vasudevan commented on HBASE-6698:
-----------------------------------------------
I tried running all the failed testcases. All of them passed.
{code}
2012-09-10 22:38:21,013 INFO [main] hbase.HBaseTestingUtility(288): Created
new mini-cluster data directory:
D:\HBase\Trunk\hbase-server\target\test-data\1b34c2bc-9ae2-4c2c-a17e-a7a7ef73b1b6\dfscluster_1f11df5c-39e2-47e7-bf7b-634dbebf785a
2012-09-10 22:38:21,540 INFO [main] zookeeper.MiniZooKeeperCluster(196):
Started MiniZK Cluster and connect 1 ZK server on client port: 50620
2012-09-10 22:38:21,549 ERROR [main] hbase.ResourceChecker(129): Bad
configuration: the operating systems file handles maximum is 0 our is 1024
2012-09-10 22:38:21,971 INFO [main] hbase.ResourceChecker(144): before
master.TestAssignmentManager#testShutdownHandler: 10 threads, 0 file
descriptors 0 connections,
2012-09-10 22:38:22,371 DEBUG [main] zookeeper.ZKUtil(102): mockedServer
opening connection to ZooKeeper with ensemble (localhost:50620)
2012-09-10 22:38:22,435 INFO [main] zookeeper.RecoverableZooKeeper(101): The
identifier of this process is 4624@Ram
2012-09-10 22:38:22,569 DEBUG [main-EventThread]
zookeeper.ZooKeeperWatcher(261): mockedServer Received ZooKeeper Event,
type=None, state=SyncConnected, path=null
2012-09-10 22:38:22,580 DEBUG [main-EventThread]
zookeeper.ZooKeeperWatcher(338): mockedServer-0x139b127390f0000 connected
2012-09-10 22:38:24,517 DEBUG [main] executor.ExecutorService(132): Starting
executor service name=MASTER_OPEN_REGION-testShutdownHandler, corePoolSize=3,
maxPoolSize=3
2012-09-10 22:38:24,518 DEBUG [main] executor.ExecutorService(132): Starting
executor service name=MASTER_CLOSE_REGION-testShutdownHandler, corePoolSize=3,
maxPoolSize=3
2012-09-10 22:38:24,518 DEBUG [main] executor.ExecutorService(132): Starting
executor service name=MASTER_SERVER_OPERATIONS-testShutdownHandler,
corePoolSize=3, maxPoolSize=3
2012-09-10 22:38:24,518 DEBUG [main] executor.ExecutorService(132): Starting
executor service name=MASTER_META_SERVER_OPERATIONS-testShutdownHandler,
corePoolSize=3, maxPoolSize=3
2012-09-10 22:38:26,200 INFO [main] handler.ServerShutdownHandler(181):
Skipping log splitting for example.org,1234,5678
2012-09-10 22:38:26,461 DEBUG [main] client.ClientScanner(94): Creating scanner
over .META. starting at key ''
2012-09-10 22:38:26,461 DEBUG [main] client.ClientScanner(205): Advancing
internal scanner to startKey at ''
2012-09-10 22:38:26,781 DEBUG [main] client.ClientScanner(192): Finished with
scanning at {NAME => 't,,1347296900866.db9424ce7e14acb58b9420b098b996ea.',
STARTKEY => '', ENDKEY => '', ENCODED => db9424ce7e14acb58b9420b098b996ea,}
2012-09-10 22:38:26,801 INFO [main] handler.ServerShutdownHandler(282):
Reassigning 1 region(s) that example.org,1234,5678 was carrying (skipping 0
regions(s) that are already in transition)
2012-09-10 22:38:26,801 INFO [main] handler.ServerShutdownHandler(378): The
table t was deleted. Hence not proceeding.
2012-09-10 22:38:26,801 INFO [main] master.AssignmentManager(1372): Quickly
assigning 0 region(s) across 2 server(s)
2012-09-10 22:38:26,801 INFO [main] master.AssignmentManager(1377): Failed
getting bulk plan, assigning region singly
2012-09-10 22:38:26,801 INFO [main] handler.ServerShutdownHandler(359):
Finished processing of shutdown of example.org,1234,5678
2012-09-10 22:38:26,801 DEBUG [main] zookeeper.ZKAssign(538):
mockedServer-0x139b127390f0000 Deleting any existing unassigned nodes
2012-09-10 22:38:26,832 DEBUG [main] zookeeper.ZKAssign(538):
mockedServer-0x139b127390f0000 Deleting any existing unassigned nodes
2012-09-10 22:38:26,853 INFO [main] hbase.ResourceChecker(144): after
master.TestAssignmentManager#testShutdownHandler: 12 threads (was 10), 0 file
descriptors 1 connections, -thread leak?-
2012-09-10 22:38:27,863 INFO [main] zookeeper.MiniZooKeeperCluster(238):
Shutdown MiniZK cluster with all ZK servers
{code}
Also could not find the error that occured while running testShutDownHandler.
The code is the updated one? Am i missing something here?
> Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
> ------------------------------------------------------------------
>
> Key: HBASE-6698
> URL: https://issues.apache.org/jira/browse/HBASE-6698
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Fix For: 0.96.0
>
> Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch,
> HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, HBASE-6698.patch
>
>
> Currently the checkAndPut and checkAndDelete api internally calls the
> internalPut and internalDelete. May be we can just call doMiniBatchMutation
> only. This will help in future like if we have some hooks and the CP
> handles certain cases in the doMiniBatchMutation the same can be done while
> doing a put thro checkAndPut or while doing a delete thro checkAndDelete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
