[
https://issues.apache.org/jira/browse/HBASE-6758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473419#comment-13473419
]
Jean-Daniel Cryans commented on HBASE-6758:
-------------------------------------------
Ah I see, I didn't fully grok the new preRoll/postRoll dance in my first
review. That's clever.
My one last concern before committing would be what happens when we are able to
compute a new HLog name and put it up in ZK, but then fail to create the HLog
and the RS dies. Will the recovered queue hang or will it abandon that HLog?
FWIW there's another jira regarding that problem but this could be a new
failure case.
> [replication] The replication-executor should make sure the file that it is
> replicating is closed before declaring success on that file
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6758
> URL: https://issues.apache.org/jira/browse/HBASE-6758
> Project: HBase
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6758-1-0.92.patch, 6758-2-0.92.patch,
> 6758-trunk-1.patch, 6758-trunk-2.patch, 6758-trunk-3.patch,
> TEST-org.apache.hadoop.hbase.replication.TestReplication.xml
>
>
> I have seen cases where the replication-executor would lose data to replicate
> since the file hasn't been closed yet. Upon closing, the new data becomes
> visible. Before that happens the ZK node shouldn't be deleted in
> ReplicationSourceManager.logPositionAndCleanOldLogs. Changes need to be made
> in ReplicationSource.processEndOfFile as well (currentPath related).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
