[
https://issues.apache.org/jira/browse/HBASE-6758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473670#comment-13473670
]
Devaraj Das commented on HBASE-6758:
------------------------------------
bq. I disagree. Right now we add the log in ZK under postLogRoll() and
createWriterInstance will run before that so the file should exist at least.
Ah! and Ooops! I forgot about the fact that I changed the code to have
preLogRoll not be ignored in the replication handler. Sorry, all the time I was
thinking about the change in the placement of the call to postLogRoll.. So yes,
it could happen that the logfile is up in ZK before the file exists but it
appears (as we just discussed in the previous comments) that the issue would
take care of itself (the RS that picks this file would dump it after some
retries)...
> [replication] The replication-executor should make sure the file that it is
> replicating is closed before declaring success on that file
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6758
> URL: https://issues.apache.org/jira/browse/HBASE-6758
> Project: HBase
> Issue Type: Bug
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 6758-1-0.92.patch, 6758-2-0.92.patch,
> 6758-trunk-1.patch, 6758-trunk-2.patch, 6758-trunk-3.patch,
> 6758-trunk-4.patch,
> TEST-org.apache.hadoop.hbase.replication.TestReplication.xml
>
>
> I have seen cases where the replication-executor would lose data to replicate
> since the file hasn't been closed yet. Upon closing, the new data becomes
> visible. Before that happens the ZK node shouldn't be deleted in
> ReplicationSourceManager.logPositionAndCleanOldLogs. Changes need to be made
> in ReplicationSource.processEndOfFile as well (currentPath related).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
