[ 
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481342#comment-13481342
 ] 

Kumar Ravi commented on HBASE-6945:
-----------------------------------


Following is a comment I added in HBASE-6965. Although related, I believe these 
are two separate issues. HBASE-6965 introduces a new Utility Bean class. This 
issue uses the new Bean class in a Junit Test case.

Please let me know if you have further questions.

Thanks!
------------------
>What JVMs and OS's did you test on out of interest? How many different vendor 
>and OS strings did you test your patch against?

This was tested on Sun (Oracle) JDK 6 (1.6.0_34), OpenJDK 6 and IBM Java 7. All 
tested on RHEL 6.3.

>It seems a big hacky looking for 'IBM' in vendor string figuring if an IBM JVM 
>or not. Are you sure it's always upper case. Any other property >you could 
>check to be sure it is the JVM you think. Does IBM only make a linux JDK?

We borrowed this idea from the code here in hadoop: 
http://svn.apache.org/repos/asf/hadoop/common/tags/release-1.0.3/src/core/org/apache/hadoop/security/UserGroupInformation.java.
 See methods getOSLoginModuleName() - Line 262 and getOsPrincipalClass() - Line 
276.

                
> Compilation errors when using non-Sun JDKs to build HBase-0.94
> --------------------------------------------------------------
>
>                 Key: HBASE-6945
>                 URL: https://issues.apache.org/jira/browse/HBASE-6945
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.94.1
>         Environment: RHEL 6.3, IBM Java 7 
>            Reporter: Kumar Ravi
>            Assignee: Kumar Ravi
>              Labels: patch
>             Fix For: 0.94.3
>
>         Attachments: ResourceCheckerJUnitListener_HBASE_6945-trunk.patch
>
>
> When using IBM Java 7 to build HBase-0.94.1, the following comilation error 
> is seen. 
> [INFO] -------------------------------------------------------------
> [ERROR] COMPILATION ERROR : 
> [INFO] -------------------------------------------------------------
> [ERROR] 
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
>  error: package com.sun.management does not exist
> [ERROR] 
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
>  error: cannot find symbol
> [ERROR]   symbol:   class UnixOperatingSystemMXBean
>   location: class ResourceAnalyzer
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
>  error: cannot find symbol
> [ERROR]   symbol:   class UnixOperatingSystemMXBean
>   location: class ResourceAnalyzer
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
>  error: cannot find symbol
> [INFO] 4 errors 
> [INFO] -------------------------------------------------------------
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] 
> ------------------------------------------------------------------------
>  I have a patch available which should work for all JDKs including Sun.
>  I am in the process of testing this patch. Preliminary tests indicate the 
> build is working fine with this patch. I will post this patch when I am done 
> testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to