[ https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487050#comment-13487050 ]
Kumar Ravi commented on HBASE-6945: ----------------------------------- stack, I see your point about leaving an empty method. As I commented earlier, the functionality of this class is already there in the OSMXBean (and will be there in the new JVMBean(?) class). The issue that one runs into when using the current calls in the abstract static class OSResourceAnalyzer, is that UnixOperatingSystemMXBean is not available in some JVMs like IBM which is what necessitated the need for the OSMXBean class. These lines are basically the body of the method. I wanted to avoid messing around with the structure of the ResourceCheckerJunitListener class, as it would change a lot of things. If something needs to be included in the method, I can reinstate the line osStats = ManagementFactory.getOperatingSystemMXBean();, and add a new constructor to OSMXBean. Lines that won't compile with IBM Java due to unavailability of UnixOperatingSystemMXBean: - if (osStats instanceof UnixOperatingSystemMXBean) { - unixOsStats = (UnixOperatingSystemMXBean) osStats; - } else { - unixOsStats = null; > Compilation errors when using non-Sun JDKs to build HBase-0.94 > -------------------------------------------------------------- > > Key: HBASE-6945 > URL: https://issues.apache.org/jira/browse/HBASE-6945 > Project: HBase > Issue Type: Bug > Components: build > Affects Versions: 0.94.1 > Environment: RHEL 6.3, IBM Java 7 > Reporter: Kumar Ravi > Assignee: Kumar Ravi > Labels: patch > Fix For: 0.94.4 > > Attachments: ResourceCheckerJUnitListener_HBASE_6945-trunk.patch > > > When using IBM Java 7 to build HBase-0.94.1, the following comilation error > is seen. > [INFO] ------------------------------------------------------------- > [ERROR] COMPILATION ERROR : > [INFO] ------------------------------------------------------------- > [ERROR] > /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25] > error: package com.sun.management does not exist > [ERROR] > /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25] > error: cannot find symbol > [ERROR] symbol: class UnixOperatingSystemMXBean > location: class ResourceAnalyzer > /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29] > error: cannot find symbol > [ERROR] symbol: class UnixOperatingSystemMXBean > location: class ResourceAnalyzer > /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23] > error: cannot find symbol > [INFO] 4 errors > [INFO] ------------------------------------------------------------- > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > I have a patch available which should work for all JDKs including Sun. > I am in the process of testing this patch. Preliminary tests indicate the > build is working fine with this patch. I will post this patch when I am done > testing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira