[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492740#comment-13492740 ]
stack commented on HBASE-7110: ------------------------------ I suggest naming it other than StoreUtils because our convention up to this is that a class with Utils suffix sits over in util package. Going by its current content, it could be used 'externally' given it a bunch of static methods that you pass in lists of StoreFiles. Why ain't this class called StoreFileUtils or StoreFileTool or just be methods on end of StoreFile? If it has been renamed Policy, thats good. Will wait on Enis review before commit. > refactor the compaction selection and config code similarly to 0.89-fb changes > ------------------------------------------------------------------------------ > > Key: HBASE-7110 > URL: https://issues.apache.org/jira/browse/HBASE-7110 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.96.0 > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Attachments: HBASE-6371-v5-refactor-only-squashed.patch > > > Separate JIRA for refactoring changes from HBASE-7055 (and further ones after > code review) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira