[ https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502205#comment-13502205 ]
Sergey Shelukhin commented on HBASE-7110: ----------------------------------------- bq I think HStore.getTtl() should just returns the configured this.ttl, and should not look at min versions. Looking at min versions only apply at the compaction selection for expiry. Renamed for clarity. See javadoc for StoreConfiguration, I hope that such bits of special logic that are currently shared in multiple places/just live where convenient can be unified there. bq Some lines exceed 100 chars. Fixed all/most/some old lines too :) > refactor the compaction selection and config code similarly to 0.89-fb changes > ------------------------------------------------------------------------------ > > Key: HBASE-7110 > URL: https://issues.apache.org/jira/browse/HBASE-7110 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.96.0 > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Attachments: HBASE-6371-v5-refactor-only-squashed.patch, > HBASE-7110-v6-squashed.patch > > > Separate JIRA for refactoring changes from HBASE-7055 (and further ones after > code review) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira