[
https://issues.apache.org/jira/browse/HBASE-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494431#comment-13494431
]
Ted Yu commented on HBASE-7062:
-------------------------------
Patch v3 looks nice.
nit: it would be nice if sentences all end with period:
{code}
+ static final String APPEND_SIZE_DESC = "Size of the data appended to the
HLog";
+ static final String SLOW_APPEND_COUNT = "slowAppendCount";
+ static final String SLOW_APPEND_COUNT_DESC = "Number of appends that were
slow.";
{code}
{code}
+ * Add the time it took to append to a histogram.
+ */
+ void incrementAppendTime(long time);
{code}
'histogram' should be 'HLog'
{code}
+ * Add the time it took to sync the hlog to a histogram.
+ */
+ void incrementSyncTime(long time);
{code}
'sync the hlog to a histogram' -> 'sync the hlog to hdfs'
{code}
- HLogMetrics.syncTime.inc(System.currentTimeMillis() - now);
+ this.metrics.finishSync(System.currentTimeMillis() - now);
{code}
nit: use EnvironmentEdge above.
{code}
+@InterfaceAudience.Private
+public class MetricsHLog {
{code}
Add class javadoc for MetricsHLog.
> Move HLog stats to metrics 2
> ----------------------------
>
> Key: HBASE-7062
> URL: https://issues.apache.org/jira/browse/HBASE-7062
> Project: HBase
> Issue Type: Sub-task
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-7062-1.patch, HBASE-7062-2.patch,
> HBASE-7062-3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
