[
https://issues.apache.org/jira/browse/HBASE-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496592#comment-13496592
]
stack commented on HBASE-7062:
------------------------------
So, a new bean for hlog. Nice that it slots under regionserver. Call the bean
'wal' instead? (Change this too: "Metrics about HBase RegionServer HLog";)
Looks like you should rename some classes too... MetricsSourceHLogImpl,
MetricsHLog... etc. HLog is an abomination of a name. WAL tells you more what
it is about where HLog says nought, worse, is misleading even. Are those bytes
or megs for size or what? If I hover over the metric will it tell me -- it
doesn't look like the description identifies the unit size?
They are kinda beautiful.
Your BaseSource in wal class should reference the other BaseSource stuff so it
can be seen that there is a pattern going on here.
slow log time should be configurable? i.e. + if (time > 1000) {... can do
that in another issue.
Patch looks good to me otherwise.
> Move HLog stats to metrics 2
> ----------------------------
>
> Key: HBASE-7062
> URL: https://issues.apache.org/jira/browse/HBASE-7062
> Project: HBase
> Issue Type: Sub-task
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-7062-1.patch, HBASE-7062-2.patch,
> HBASE-7062-3.patch, HBASE-7062-4.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
