[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499535#comment-13499535 ]
Ted Yu commented on HBASE-6787: ------------------------------- nit: on review board, I can see a few white spaces. {code} +public class RowProcessorClient { {code} Please add short javadoc and annotation for audience. {code} + * The request argument contains the processor. The processor object defines ... * @return The processing result */ ... + public void process(RpcController controller, RowProcessorRequest request, {code} There is no return value any more. The request contains information for constructing processor (see constructRowProcessorFromRequest), I think the first sentence above should be slightly modified. {code} + Class<?> superClass = processor.getClass(); + Type type = superClass.getGenericSuperclass(); {code} The variable naming above might be a little confusing :-) {code} + Type t1 = ((ParameterizedType)type).getActualTypeArguments()[1]; {code} Do you need to check that there're two type arguments ? {code} -public abstract class BaseRowProcessor<T> implements RowProcessor<T> { +public abstract class BaseRowProcessor<S extends Message,T extends Message> {code} Better describe what the two Messages mean. This is javadoc at the beginning of RowProcessor. It would be nice to elaborate above. > Convert RowProcessorProtocol to protocol buffer service > ------------------------------------------------------- > > Key: HBASE-6787 > URL: https://issues.apache.org/jira/browse/HBASE-6787 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors > Reporter: Gary Helmling > Assignee: Devaraj Das > Fix For: 0.96.0 > > Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch > > > With coprocessor endpoints now exposed as protobuf defined services, we > should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira