[ 
https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502218#comment-13502218
 ] 

Gary Helmling commented on HBASE-6787:
--------------------------------------

Since HBASE-7185 went in (moving .proto files and generates sources under 
hbase-protocol module), the latest patch needs to be updated to move the PB 
bits as well.

I like the updates to RowProcessor adding a type param for request as well as 
response.  And making these extend Message means implementors don't actually 
have to worry about the serialization bits.

Overall this version looks good.  Can you update the patch to account for the 
HBASE-7185 changes?
                
> Convert RowProcessorProtocol to protocol buffer service
> -------------------------------------------------------
>
>                 Key: HBASE-6787
>                 URL: https://issues.apache.org/jira/browse/HBASE-6787
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Gary Helmling
>            Assignee: Devaraj Das
>             Fix For: 0.96.0
>
>         Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 
> 6787-5.patch, 6787-6.patch
>
>
> With coprocessor endpoints now exposed as protobuf defined services, we 
> should convert over all of our built-in endpoints to PB services.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to