[ 
https://issues.apache.org/jira/browse/HBASE-7191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501523#comment-13501523
 ] 

Devaraj Das commented on HBASE-7191:
------------------------------------

Haven't looked at the patch in detail but some things that you should take care 
of: 
(1) indentation of code (two spaces, look at the existing code for getting a 
feel of how it should look like).
(2) patch should be submitted for trunk first (ideally)
There are flaky tests in the codebase. If you see an unrelated test failing on 
hudson, and the test passes locally, please make a note of it as a comment on 
jira.
                
> HBCK - Add offline create/fix hbase.version and hbase.id 
> ---------------------------------------------------------
>
>                 Key: HBASE-7191
>                 URL: https://issues.apache.org/jira/browse/HBASE-7191
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbck
>    Affects Versions: 0.94.1
>            Reporter: Enis Soztutar
>         Attachments: 7191-2.patch
>
>
> One of our clients run into a problem, in which they have the hbase.root.dir, 
> and cluster data, but their hbase.id and hbase.version files are corrupted. 
> HMaster creates those on start, but not if there is already existing data.
> We can add smt like --fixIdFile, and ability for HBCK to do some offline 
> repairs for the version file. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to