[ 
https://issues.apache.org/jira/browse/HBASE-7191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501528#comment-13501528
 ] 

Ted Yu commented on HBASE-7191:
-------------------------------

For OfflineVersionAndClusterIdFixTests.java, usually test class starts with 
Test. Name it TestOfflineVersionAndClusterIdFix
It should carry the following annotation:
{code}
@Category(SmallTests.class)
{code}
{code}
-      System.exit(success ? 0 : 1);
+     shutDownFsck(fsck);
{code}
Can you log the value of success above ?
For shutDownFsck(), can you add a method in HBaseFsck which shuts down executor 
?
                
> HBCK - Add offline create/fix hbase.version and hbase.id 
> ---------------------------------------------------------
>
>                 Key: HBASE-7191
>                 URL: https://issues.apache.org/jira/browse/HBASE-7191
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbck
>    Affects Versions: 0.94.1
>            Reporter: Enis Soztutar
>         Attachments: 7191-2.patch
>
>
> One of our clients run into a problem, in which they have the hbase.root.dir, 
> and cluster data, but their hbase.id and hbase.version files are corrupted. 
> HMaster creates those on start, but not if there is already existing data.
> We can add smt like --fixIdFile, and ability for HBCK to do some offline 
> repairs for the version file. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to