[
https://issues.apache.org/jira/browse/HBASE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502285#comment-13502285
]
stack commented on HBASE-7110:
------------------------------
Looking at patch:
FYI:
{code}
-import org.apache.hadoop.hbase.regionserver.compactions.CompactSelection;
-import org.apache.hadoop.hbase.regionserver.compactions.CompactionProgress;
-import org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest;
+import org.apache.hadoop.hbase.regionserver.compactions.*;
{code}
... not a show stopper but better to list individual imports than use '*'.
This has to be public?
getStoreFileTtl
So it can be picked up by compaction code?
And these need to be public too for same reason?
getMajorCompactionPeriod
getMemstoreFlushSize
In Store there are imports but they are not used?
+import java.lang.reflect.InvocationTargetException;
+import java.util.Collection;
Yeah, why you making stuff public in StoreFile? So can be reached from
compaction package?
Should StoreUtils be public? Should it be private to this package?
Patch is good. Anything that can be done about reaching between packages and
opening up methods that were previously package protected?
The small stuff in the above I can address on commit.
> refactor the compaction selection and config code similarly to 0.89-fb changes
> ------------------------------------------------------------------------------
>
> Key: HBASE-7110
> URL: https://issues.apache.org/jira/browse/HBASE-7110
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-6371-v5-refactor-only-squashed.patch,
> HBASE-7110-v6-squashed.patch, HBASE-7110-v7.patch
>
>
> Separate JIRA for refactoring changes from HBASE-7055 (and further ones after
> code review)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
