[ https://issues.apache.org/jira/browse/HBASE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529419#comment-13529419 ]
Andrew Purtell commented on HBASE-7205: --------------------------------------- HBASE-7326 makes sense. Let's do it. The v10 patch looks mostly ok. I like the test improvements. This hunk contains an error: {noformat} Index: hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorClassLoader.java =================================================================== --- hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorClassLoader.java (revision 1419585) +++ hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorClassLoader.java (working copy) @@ -65,9 +65,13 @@ "org.w3c", "org.xml", "sunw.", - // Hadoop/HBase: + // logging + "org.apache.commons.logging", + "org.apache.log4j", + "com.hadoop", + // Hadoop/HBase/ZK: "org.apache.hadoop", - "com.hadoop", + "org.apache.zookeeper", }; /** {noformat} Don't remove "com.hadoop" from the whitelist. See HBASE-6843. > Coprocessor classloader is replicated for all regions in the HRegionServer > -------------------------------------------------------------------------- > > Key: HBASE-7205 > URL: https://issues.apache.org/jira/browse/HBASE-7205 > Project: HBase > Issue Type: Bug > Components: Coprocessors > Affects Versions: 0.92.2, 0.94.2 > Reporter: Adrian Muraru > Assignee: Ted Yu > Priority: Critical > Fix For: 0.96.0, 0.94.4 > > Attachments: 7205-v10.txt, 7205-v1.txt, 7205-v3.txt, 7205-v4.txt, > 7205-v5.txt, 7205-v6.txt, 7205-v7.txt, 7205-v8.txt, 7205-v9.txt, > HBASE-7205_v2.patch > > > HBASE-6308 introduced a new custom CoprocessorClassLoader to load the > coprocessor classes and a new instance of this CL is created for each single > HRegion opened. This leads to OOME-PermGen when the number of regions go > above hundres / region server. > Having the table coprocessor jailed in a separate classloader is good however > we should create only one for all regions of a table in each HRS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira