[
https://issues.apache.org/jira/browse/HBASE-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532069#comment-13532069
]
stack commented on HBASE-6788:
------------------------------
I went over the patch again. I think I follow what is going on. This
AuthenticationTokenIdentifier implements the Hadoop TokenIdentifier. Its a
Writable and nought you can do about it, not at moment, so you are outputting
pb when write and expecting pb when you readFrom. That seems to make sense
given the constraint.
Is this needed anymore?
public static final long VERSION = 0L;
Why do this Gary?
+ return
AuthenticationProtos.AuthenticationService.newReflectiveService(this);
Why can't we just return 'this'?
Else patch looks good (again)
> Convert AuthenticationProtocol to protocol buffer service
> ---------------------------------------------------------
>
> Key: HBASE-6788
> URL: https://issues.apache.org/jira/browse/HBASE-6788
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: HBASE-6788.patch
>
>
> With coprocessor endpoints now exposed as protobuf defined services, we
> should convert over all of our built-in endpoints to PB services.
> AccessControllerProtocol was converted as part of HBASE-5448, but the
> authentication token provider still needs to be changed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
