[ 
https://issues.apache.org/jira/browse/HBASE-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532100#comment-13532100
 ] 

Gary Helmling commented on HBASE-6788:
--------------------------------------

[~saint....@gmail.com] Thanks for the review.  Sorry to update it again just 
after you've taken a look.

bq. This AuthenticationTokenIdentifier implements the Hadoop TokenIdentifier. 

Yes, AuthenticationTokenIdentifier still needs to retain the Writable interface 
since Token (Hadoop class) uses this internally, and we rely on Token to tie in 
transparently to the Hadoop UGI credentials.

bq. public static final long VERSION = 0L;

Nice catch, no longer needed.

bq. + return 
AuthenticationProtos.AuthenticationService.newReflectiveService(this);

Since TokenProvider implements AuthenticationService.Interface, this translates 
that back into a Service instance.
                
> Convert AuthenticationProtocol to protocol buffer service
> ---------------------------------------------------------
>
>                 Key: HBASE-6788
>                 URL: https://issues.apache.org/jira/browse/HBASE-6788
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6788.patch
>
>
> With coprocessor endpoints now exposed as protobuf defined services, we 
> should convert over all of our built-in endpoints to PB services.
> AccessControllerProtocol was converted as part of HBASE-5448, but the 
> authentication token provider still needs to be changed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to