[
https://issues.apache.org/jira/browse/HBASE-6651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533589#comment-13533589
]
Hiroshi Ikeda commented on HBASE-6651:
--------------------------------------
The Stable annotation is only used to indicate a contract between developers
and users, and its javadoc says "Can evolve while retaining compatibility for
minor release boundaries.; can break compatibility only at major release (ie.
at m.0). ", and definitely most users believe this and create their application
using "stable" API. I'm not sure about the official vote, but I think it is not
sufficient to break faith with all users in the world.
> Improve thread safety of HTablePool
> -----------------------------------
>
> Key: HBASE-6651
> URL: https://issues.apache.org/jira/browse/HBASE-6651
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.94.1
> Reporter: Hiroshi Ikeda
> Assignee: Hiroshi Ikeda
> Fix For: 0.96.0
>
> Attachments: HBASE-6651.patch, HBASE-6651-V10.patch,
> HBASE-6651-V2.patch, HBASE-6651-V3.patch, HBASE-6651-V4.patch,
> HBASE-6651-V5.patch, HBASE-6651-V6.patch, HBASE-6651-V7.patch,
> HBASE-6651-V8.patch, HBASE-6651-V9.patch, sample.zip, sample.zip,
> sharedmap_for_hbaseclient.zip
>
>
> There are some operations in HTablePool accessing PoolMap in multiple places
> without any explicit synchronization.
> For example HTablePool.closeTablePool() calls PoolMap.values(), and calls
> PoolMap.remove(). If other threads add new instances to the pool in the
> middle of the calls, the newly added instances might be dropped.
> (HTablePool.closeTablePool() also has another problem that calling it by
> multiple threads causes accessing HTable by multiple threads.)
> Moreover, PoolMap is not thread safe for the same reason.
> For example PoolMap.put() calles ConcurrentMap.get() and calles
> ConcurrentMap.put(). If other threads add a new instance to the concurent map
> in the middle of the calls, the new instance might be dropped.
> And also implementations of Pool have the same problems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
