[ 
https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539027#comment-13539027
 ] 

nkeywal commented on HBASE-5598:
--------------------------------

Note it's also possible to have tags in the code to suppress a warning: 
http://stackoverflow.com/questions/249536/when-using-eclipse-with-findbugs-can-you-mark-a-bug-as-not-a-bug-and-have-it-rem

{code}
@edu.umd.cs.findbugs.annotations.SuppressWarnings(
    value="EQ_COMPARETO_USE_OBJECT_EQUALS", 
    justification="because I know better")
{code} 

It's not the standard SuppressWarnings: it requires to link with findbugs jars.
                
> Analyse and fix the findbugs reporting by QA and add invalid bugs into 
> findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5598
>                 URL: https://issues.apache.org/jira/browse/HBASE-5598
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.92.1, 0.94.0, 0.96.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 5598.part1.patch, 
> ASF.LICENSE.NOT.GRANTED--findbugs-gui-report.jpg, HBASE-5598.patch
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to 
> up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new 
> valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the 
> invalid bugs). If we find any valid ones, we can fix under this JIRA.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to