[
https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540050#comment-13540050
]
nkeywal commented on HBASE-5598:
--------------------------------
bq. @nkeywal Do you want to do part2 in another issue linked to from here since
we have already committed a patch against this issue?
Ok, I will do that.
bq. Why move the defines in HRegionInfo?
We're constructing an object while the static fields are not yet all
initialized:
{code}
class A{
static A = new A();
static int i = 15;
A(){ print "i=" + i; }
}
{code}
prints i=0;
Tricky isn't it?
bq. return new StringBuilder("AuthResult")
.append(toContextString()).toString();
+ return "AuthResult" + toContextString();
Don't remember its name (it could be an IntelliJ warning as well, I fix both),
but it's just that the new code is simpler and at least as efficient as the
previous one, as "AuthResult" is a constant.
bq. We are going back to findbugs 2.0.1 from 2.5.2?
There are two versions, one for findbugs, one for the maven plugin. Maven
plugin 2.5.2 includes findbugs 2.0.1.
The naming was previously confusing, so I renamed the variables.
And we need to explicitly define the two versions, as we're including the
plugin but as well the annotations.
Last findbugs is 2.0.2, but I put 2.0.1 to match the version included by the
maven plugin
bq. Is this define used anywhere: findbugs-maven-plugin.version
Yep, in the main pom, when including the maven plugin.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into
> findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 5598.part1.patch, 5598.part2.patch, 5598.part2.patch,
> ASF.LICENSE.NOT.GRANTED--findbugs-gui-report.jpg, HBASE-5598.patch
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to
> up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new
> valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the
> invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
