[ https://issues.apache.org/jira/browse/HBASE-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595398#comment-13595398 ]
Sergey Shelukhin commented on HBASE-8011: ----------------------------------------- 1. I was referring to "create sane a" 2. Can you add comment that explains the null check? > Refactor ImportTsv > ------------------ > > Key: HBASE-8011 > URL: https://issues.apache.org/jira/browse/HBASE-8011 > Project: HBase > Issue Type: Improvement > Components: mapreduce, Usability > Reporter: Nick Dimiduk > Assignee: Nick Dimiduk > Priority: Minor > Attachments: 0001-HBASE-8011-Refactor-ImportTsv.patch > > > ImportTsv is a little goofy. > - It doesn't use the Tool,Configured interfaces like a mapreduce job should. > - It has a static HBaseAdmin field that must be initialized before the > intended API of createSubmittableJob can be invoked. > - TsvParser is critical to the default mapper implementation but is > unavailable to user custom mapper implementations without forcing them into > the o.a.h.h.mapreduce namespace. > - The configuration key constants are not public. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira