[ 
https://issues.apache.org/jira/browse/HBASE-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597519#comment-13597519
 ] 

Nick Dimiduk commented on HBASE-8011:
-------------------------------------

bq. Patch seems good. I am just wondering whether users really need to override 
the importtsv mapper.

The user's I've spoken with don't find this tool to be very useful for 
real-world workflows. Almost everyone ends up writing custom Import code.
                
> Refactor ImportTsv
> ------------------
>
>                 Key: HBASE-8011
>                 URL: https://issues.apache.org/jira/browse/HBASE-8011
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce, Usability
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Minor
>         Attachments: 0001-HBASE-8011-Refactor-ImportTsv.patch, 
> 0001-HBASE-8011-Refactor-ImportTsv.patch
>
>
> ImportTsv is a little goofy.
>  - It doesn't use the Tool,Configured interfaces like a mapreduce job should.
>  - It has a static HBaseAdmin field that must be initialized before the 
> intended API of createSubmittableJob can be invoked.
>  - TsvParser is critical to the default mapper implementation but is 
> unavailable to user custom mapper implementations without forcing them into 
> the o.a.h.h.mapreduce namespace.
>  - The configuration key constants are not public.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to