[ https://issues.apache.org/jira/browse/HBASE-7836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620050#comment-13620050 ]
Ted Yu commented on HBASE-7836: ------------------------------- {code} + * When a regon is in recovering state, it can only accept writes not reads {code} typo: regon For batchMutate(), please add javadoc for param inReplay: {code} + OperationStatus[] batchMutate( + Pair<Mutation, Integer>[] mutationsAndLocks, boolean inReplay) throws IOException { {code} In javadoc, should state that doPreMutationHook() would not be called if region is in replay state. Should the following existing method be extended / merged with the above new method ? {code} public OperationStatus[] batchMutate( Pair<Mutation, Integer>[] mutationsAndLocks) throws IOException { {code} In HRegionServer.java, {code} - this.recoveringRegions.add(region.getEncodedName()); + this.recoveringRegions.put(region.getEncodedName(), null); {code} Why the value of null is used above ? > Create a new "replay" command so that recovered edits won't mess up normal > coprocessing & metrics > ------------------------------------------------------------------------------------------------- > > Key: HBASE-7836 > URL: https://issues.apache.org/jira/browse/HBASE-7836 > Project: HBase > Issue Type: Sub-task > Reporter: Jeffrey Zhong > Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7836_v1.patch, hbase-7836_v2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira