[
https://issues.apache.org/jira/browse/HBASE-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13669488#comment-13669488
]
Nick Dimiduk commented on HBASE-8534:
-------------------------------------
These changes look great. A couple questions
- how does the {{LauncherSecurityManager}} behave when multiple tests are run
in parallel?
- from {{TestLoadIncrementalHFiles}}, was {{verifyAssignedSequenceNumber}}
simply never called?
from LauncherSecurityManager:
{noformat}
public LauncherSecurityManager() {
reset();
securityManager = System.getSecurityManager();
System.setSecurityManager(this);
}
{noformat}
Construction should not modify system state. I'd rather see each test manage
setting and resetting the manager rather than part of it happen in the tests
and part in this constructor.
>From TestTableMapReduceUtil:
{noformat}
assertEquals(
"org.apache.hadoop.io.serializer.WritableSerialization," +
"org.apache.hadoop.hbase.mapreduce.MutationSerialization," +
"org.apache.hadoop.hbase.mapreduce.ResultSerialization," +
"org.apache.hadoop.hbase.mapreduce.KeyValueSerialization",
job.getConfiguration().get("io.serializations"));
{noformat}
What happens if the user's environment has other serializers installed, won't
this test always fail for them? Instead, these assertEquals should be replaced
by asserts over string containment. I'm open to suggestions as for how to
assert order of containment.
TestHRegionPartitioner doesn't run a job, it only spins up a cluster. I think
it can be marked a MediumTest.
TestGroupingTableMapper can be marked a SmallTest.
TestDriver can be marked a SmallTest.
> fix coverage org.apache.hadoop.hbase.mapreduce
> ----------------------------------------------
>
> Key: HBASE-8534
> URL: https://issues.apache.org/jira/browse/HBASE-8534
> Project: HBase
> Issue Type: Test
> Affects Versions: 0.94.8, 0.95.2
> Reporter: Aleksey Gorshkov
> Attachments: HBASE-8534-0.94-d.patch, HBASE-8534-0.94-e.patch,
> HBASE-8534-0.94.patch, HBASE-8534-trunk-a.patch, HBASE-8534-trunk-b.patch,
> HBASE-8534-trunk-c.patch, HBASE-8534-trunk-d.patch, HBASE-8534-trunk-e.patch,
> HBASE-8534-trunk.patch
>
>
> fix coverage org.apache.hadoop.hbase.mapreduce
> patch HBASE-8534-0.94.patch for branch-0.94
> patch HBASE-8534-trunk.patch for branch-0.95 and trunk
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
