[ https://issues.apache.org/jira/browse/HIVE-17852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475077#comment-16475077 ]
Hive QA commented on HIVE-17852: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12923260/HIVE-17852.02.patch {color:green}SUCCESS:{color} +1 due to 34 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 14393 tests executed *Failed tests:* {noformat} TestNonCatCallsWithCatalog - did not produce a TEST-*.xml file (likely timed out) (batchId=217) TestTxnExIm - did not produce a TEST-*.xml file (likely timed out) (batchId=286) org.apache.hadoop.hive.cli.TestMiniDruidKafkaCliDriver.testCliDriver[druidkafkamini_basic] (batchId=253) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[default_constraint] (batchId=163) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourceplan] (batchId=167) org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=225) org.apache.hadoop.hive.metastore.TestStats.partitionedTableInHiveCatalog (batchId=211) org.apache.hadoop.hive.metastore.TestStats.partitionedTableOtherCatalog (batchId=211) org.apache.hive.beeline.TestBeeLineWithArgs.testQueryProgress (batchId=236) org.apache.hive.beeline.TestBeeLineWithArgs.testQueryProgressParallel (batchId=236) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/10949/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/10949/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-10949/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 10 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12923260 - PreCommit-HIVE-Build > remove support for list bucketing "stored as directories" in 3.0 > ---------------------------------------------------------------- > > Key: HIVE-17852 > URL: https://issues.apache.org/jira/browse/HIVE-17852 > Project: Hive > Issue Type: Bug > Reporter: Sergey Shelukhin > Assignee: Laszlo Bodor > Priority: Major > Attachments: HIVE-17852.01.patch, HIVE-17852.02.patch > > > From the email thread: > 1) LB, when stored as directories, adds a lot of low-level complexity to Hive > tables that has to be accounted for in many places in the code where the > files are written or modified - from FSOP to ACID/replication/export. > 2) While working on some FSOP code I noticed that some of that logic is > broken - e.g. the duplicate file removal from tasks, a pretty fundamental > correctness feature in Hive, may be broken. LB also doesn’t appear to be > compatible with e.g. regular bucketing. > 3) The feature hasn’t seen development activity in a while; it also doesn’t > appear to be used a lot. > Keeping with the theme of cleaning up “legacy” code for 3.0, I was proposing > we remove it. > (2) also suggested that, if needed, it might be easier to implement similar > functionality by adding some flexibility to partitions (which LB directories > look like anyway); that would also keep the logic on a higher level of > abstraction (split generation, partition pruning) as opposed to many > low-level places like FSOP, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)