[
https://issues.apache.org/jira/browse/HIVE-19718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501439#comment-16501439
]
Peter Vary commented on HIVE-19718:
-----------------------------------
[~vihangk1]: Yeah, the failures are related. Accidentally added one line to
HiveMetaStore.java.
Uploaded new patch:
Addressed RB comments, and fixed test failures:
- Added transaction to the original getMPartition method
- Added javadoc
- Removed accidentally added extra line from HiveMetaStore.java
> Adding partitions in bulk also fetches table for each partition
> ---------------------------------------------------------------
>
> Key: HIVE-19718
> URL: https://issues.apache.org/jira/browse/HIVE-19718
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 3.0.0
> Environment: Looking at {{convertToMPart}}:
> {code:Java}
> private MPartition convertToMPart(Partition part, boolean useTableCD)
> throws InvalidObjectException, MetaException {
> MTable mt = getMTable(part.getCatName(), part.getDbName(),
> part.getTableName());
> ...
> {code}
> So what we have as a result is that we fetch table for every partition where
> it should be done just once.
> Reporter: Alexander Kolbasov
> Assignee: Peter Vary
> Priority: Major
> Attachments: HIVE-19718.2.patch, HIVE-19718.3.patch,
> HIVE-19718.4.patch, HIVE-19718.patch
>
>
> The ObjectStore.addPartitions() method does this:
> {code:java}
> for (Partition part : parts) {
> if (!part.getTableName().equals(tblName) ||
> !part.getDbName().equals(dbName)) {
> throw new MetaException("Partition does not belong to target table "
> + dbName + "." + tblName + ": " + part);
> }
> MPartition mpart = convertToMPart(part, true); // <-- Here
> toPersist.add(mpart);
> ...{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
