[
https://issues.apache.org/jira/browse/HIVE-19718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503206#comment-16503206
]
Hive QA commented on HIVE-19718:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12926714/HIVE-19718.5.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14467 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11555/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11555/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11555/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12926714 - PreCommit-HIVE-Build
> Adding partitions in bulk also fetches table for each partition
> ---------------------------------------------------------------
>
> Key: HIVE-19718
> URL: https://issues.apache.org/jira/browse/HIVE-19718
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 3.0.0
> Environment: Looking at {{convertToMPart}}:
> {code:Java}
> private MPartition convertToMPart(Partition part, boolean useTableCD)
> throws InvalidObjectException, MetaException {
> MTable mt = getMTable(part.getCatName(), part.getDbName(),
> part.getTableName());
> ...
> {code}
> So what we have as a result is that we fetch table for every partition where
> it should be done just once.
> Reporter: Alexander Kolbasov
> Assignee: Peter Vary
> Priority: Major
> Attachments: HIVE-19718.2.patch, HIVE-19718.3.patch,
> HIVE-19718.4.patch, HIVE-19718.5.patch, HIVE-19718.patch
>
>
> The ObjectStore.addPartitions() method does this:
> {code:java}
> for (Partition part : parts) {
> if (!part.getTableName().equals(tblName) ||
> !part.getDbName().equals(dbName)) {
> throw new MetaException("Partition does not belong to target table "
> + dbName + "." + tblName + ": " + part);
> }
> MPartition mpart = convertToMPart(part, true); // <-- Here
> toPersist.add(mpart);
> ...{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
