[
https://issues.apache.org/jira/browse/HIVE-20207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553599#comment-16553599
]
Hive QA commented on HIVE-20207:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
21s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
22s{color} | {color:blue} storage-api in master has 48 extant Findbugs
warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 14m
12s{color} | {color:red} branch/itests/hive-jmh cannot run convertXmlToText
from findbugs {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
56s{color} | {color:blue} ql in master has 2280 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
29s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
19s{color} | {color:red} hive-jmh in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
27s{color} | {color:red} ql in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
19s{color} | {color:red} hive-jmh in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 19s{color}
| {color:red} hive-jmh in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
10s{color} | {color:red} itests/hive-jmh: The patch generated 1 new + 20
unchanged - 0 fixed = 21 total (was 20) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
46s{color} | {color:red} ql: The patch generated 86 new + 1036 unchanged - 85
fixed = 1122 total (was 1121) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} vector-code-gen: The patch generated 3 new + 319
unchanged - 0 fixed = 322 total (was 319) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
16s{color} | {color:red} hive-jmh in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
15s{color} | {color:red} ql generated 17 new + 2280 unchanged - 0 fixed = 2297
total (was 2280) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 10s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Redundant nullcheck of undecoratedTypeName, which is known to be non-null
in
org.apache.hadoop.hive.ql.exec.vector.VectorizationContext.getDecimal64VectorExpressionForUdf(GenericUDF,
Class, List, int, VectorExpressionDescriptor$Mode, TypeInfo) Redundant null
check at VectorizationContext.java:is known to be non-null in
org.apache.hadoop.hive.ql.exec.vector.VectorizationContext.getDecimal64VectorExpressionForUdf(GenericUDF,
Class, List, int, VectorExpressionDescriptor$Mode, TypeInfo) Redundant null
check at VectorizationContext.java:[line 1595] |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalColEqualDecimalScalar
defines non-transient non-serializable instance field value In
DecimalColEqualDecimalScalar.java:instance field value In
DecimalColEqualDecimalScalar.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalColGreaterDecimalScalar
defines non-transient non-serializable instance field value In
DecimalColGreaterDecimalScalar.java:instance field value In
DecimalColGreaterDecimalScalar.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalColGreaterEqualDecimalScalar
defines non-transient non-serializable instance field value In
DecimalColGreaterEqualDecimalScalar.java:instance field value In
DecimalColGreaterEqualDecimalScalar.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalColLessDecimalScalar
defines non-transient non-serializable instance field value In
DecimalColLessDecimalScalar.java:instance field value In
DecimalColLessDecimalScalar.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalColLessEqualDecimalScalar
defines non-transient non-serializable instance field value In
DecimalColLessEqualDecimalScalar.java:instance field value In
DecimalColLessEqualDecimalScalar.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalColNotEqualDecimalScalar
defines non-transient non-serializable instance field value In
DecimalColNotEqualDecimalScalar.java:instance field value In
DecimalColNotEqualDecimalScalar.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalScalarEqualDecimalColumn
defines non-transient non-serializable instance field value In
DecimalScalarEqualDecimalColumn.java:instance field value In
DecimalScalarEqualDecimalColumn.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalScalarGreaterDecimalColumn
defines non-transient non-serializable instance field value In
DecimalScalarGreaterDecimalColumn.java:instance field value In
DecimalScalarGreaterDecimalColumn.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalScalarGreaterEqualDecimalColumn
defines non-transient non-serializable instance field value In
DecimalScalarGreaterEqualDecimalColumn.java:instance field value In
DecimalScalarGreaterEqualDecimalColumn.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalScalarLessDecimalColumn
defines non-transient non-serializable instance field value In
DecimalScalarLessDecimalColumn.java:instance field value In
DecimalScalarLessDecimalColumn.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalScalarLessEqualDecimalColumn
defines non-transient non-serializable instance field value In
DecimalScalarLessEqualDecimalColumn.java:instance field value In
DecimalScalarLessEqualDecimalColumn.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalScalarNotEqualDecimalColumn
defines non-transient non-serializable instance field value In
DecimalScalarNotEqualDecimalColumn.java:instance field value In
DecimalScalarNotEqualDecimalColumn.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.IfExprDecimalColumnScalar
defines non-transient non-serializable instance field arg3Scalar In
IfExprDecimalColumnScalar.java:instance field arg3Scalar In
IfExprDecimalColumnScalar.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.IfExprDecimalScalarColumn
defines non-transient non-serializable instance field arg2Scalar In
IfExprDecimalScalarColumn.java:instance field arg2Scalar In
IfExprDecimalScalarColumn.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.IfExprDecimalScalarScalar
defines non-transient non-serializable instance field arg2Scalar In
IfExprDecimalScalarScalar.java:instance field arg2Scalar In
IfExprDecimalScalarScalar.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.IfExprDecimalScalarScalar
defines non-transient non-serializable instance field arg3Scalar In
IfExprDecimalScalarScalar.java:instance field arg3Scalar In
IfExprDecimalScalarScalar.java |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12805/dev-support/hive-personality.sh
|
| git revision | master / 4e9562f |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12805/yetus/branch-findbugs-itests_hive-jmh.txt
|
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12805/yetus/patch-mvninstall-itests_hive-jmh.txt
|
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12805/yetus/patch-mvninstall-ql.txt
|
| compile |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12805/yetus/patch-compile-itests_hive-jmh.txt
|
| javac |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12805/yetus/patch-compile-itests_hive-jmh.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12805/yetus/diff-checkstyle-itests_hive-jmh.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12805/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12805/yetus/diff-checkstyle-vector-code-gen.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12805/yetus/patch-findbugs-itests_hive-jmh.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12805/yetus/new-findbugs-ql.html
|
| modules | C: storage-api itests/hive-jmh ql vector-code-gen U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12805/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Vectorization: Fix NULL / Wrong Results issues in Filter / Compare
> ------------------------------------------------------------------
>
> Key: HIVE-20207
> URL: https://issues.apache.org/jira/browse/HIVE-20207
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Reporter: Matt McCline
> Assignee: Matt McCline
> Priority: Critical
> Attachments: HIVE-20207.01.patch, HIVE-20207.02.patch,
> HIVE-20207.03.patch, HIVE-20207.04.patch, HIVE-20207.05.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches
> to checks for NULL and Wrong Results for vectorized filter and compare.
> BUGS:
> 1)Â LongColLessLongColumn SIMD optimization do not work for very large
> integers:
> -7272907770454997143 < 8976171455044006767
> outputVector[i] = (vector1[i] - vector2[i]) >>> 63;
> Produces 0 instead of 1...
> Also, add DECIMAL_64 testing. Add missing DECIMAL/DECIMAL_64 Comparison and
> IF vectorized expression classes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
