[ 
https://issues.apache.org/jira/browse/HIVE-20207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553665#comment-16553665
 ] 

Teddy Choi commented on HIVE-20207:
-----------------------------------

LGTM +1. Thanks for fixing my mistakes. :D

> Vectorization: Fix NULL / Wrong Results issues in Filter / Compare
> ------------------------------------------------------------------
>
>                 Key: HIVE-20207
>                 URL: https://issues.apache.org/jira/browse/HIVE-20207
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Matt McCline
>            Assignee: Matt McCline
>            Priority: Critical
>         Attachments: HIVE-20207.01.patch, HIVE-20207.02.patch, 
> HIVE-20207.03.patch, HIVE-20207.04.patch, HIVE-20207.05.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches 
> to checks for NULL and Wrong Results for vectorized filter and compare.
> BUGS:
> 1) LongColLessLongColumn SIMD optimization do not work for very large 
> integers:
>  -7272907770454997143 < 8976171455044006767
>  outputVector[i] = (vector1[i] - vector2[i]) >>> 63;
>  Produces 0 instead of 1...
> Also, add DECIMAL_64 testing. Add missing DECIMAL/DECIMAL_64 Comparison and 
> IF vectorized expression classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to