[
https://issues.apache.org/jira/browse/HIVE-19368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567295#comment-16567295
]
Vihang Karajgaonkar commented on HIVE-19368:
--------------------------------------------
Test failures are not related. Looks like some other patch broke this test.
Couple of comments on the patch.
1. Can you create private static method which takes in the size of partitionIds
and reuse the method at both the places?
2. Also I think it would be useful to add the database name and API name to the
message as well. So you probably will have to pass them too. Consider using the
following msg which I think is more useful {{Log.warn("{} API is processing {}
partitions for {}.{}. Consider using a filter to reduce the number of
partitions scanned.", methodname, databaseName, tableName)}}
> Metastore: log a warning with table-name + partition-count when
> get_partitions returns >10k partitions
> ------------------------------------------------------------------------------------------------------
>
> Key: HIVE-19368
> URL: https://issues.apache.org/jira/browse/HIVE-19368
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Affects Versions: 3.1.0
> Reporter: Gopal V
> Assignee: Anurag Mantripragada
> Priority: Major
> Attachments: HIVE-19368.1.patch
>
>
> Ran into this particular letter from the trenches & would like a normal WARN
> log for it.
> https://www.slideshare.net/Hadoop_Summit/hive-at-yahoo-letters-from-the-trenches/24
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
