[
https://issues.apache.org/jira/browse/HIVE-20161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680090#comment-16680090
]
Hive QA commented on HIVE-20161:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12947276/HIVE-20161.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 15526 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/14813/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14813/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14813/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12947276 - PreCommit-HIVE-Build
> Do Not Print StackTraces to STDERR in ParseDriver
> -------------------------------------------------
>
> Key: HIVE-20161
> URL: https://issues.apache.org/jira/browse/HIVE-20161
> Project: Hive
> Issue Type: Improvement
> Components: Query Planning
> Affects Versions: 3.0.0, 4.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Labels: newbie, noob
> Attachments: HIVE-20161.1.patch
>
>
> https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
> {code}
> // Do not print stack trace to STDERR - remove this, just throw the
> HiveException
> } catch (Exception e) {
> e.printStackTrace();
> throw new HiveException(e);
> }
> ...
> // Do not log and throw. log *or* throw. In this case, just throw. Remove
> logging.
> // Remove explicit 'return' call. No need for it.
> try {
> skewJoinKeyContext.endGroup();
> } catch (IOException e) {
> LOG.error(e.getMessage(), e);
> throw new HiveException(e);
> }
> return;
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
