[ 
https://issues.apache.org/jira/browse/HIVE-20161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680513#comment-16680513
 ] 

Prasanth Jayachandran commented on HIVE-20161:
----------------------------------------------

+1

> Do Not Print StackTraces to STDERR in ParseDriver
> -------------------------------------------------
>
>                 Key: HIVE-20161
>                 URL: https://issues.apache.org/jira/browse/HIVE-20161
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Planning
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>              Labels: newbie, noob
>         Attachments: HIVE-20161.1.patch
>
>
> https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
> {code}
> // Do not print stack trace to STDERR - remove this, just throw the 
> HiveException
>     } catch (Exception e) {
>       e.printStackTrace();
>       throw new HiveException(e);
>     }
> ...
> // Do not log and throw.  log *or* throw.  In this case, just throw. Remove 
> logging.
> // Remove explicit 'return' call. No need for it.
>       try {
>         skewJoinKeyContext.endGroup();
>       } catch (IOException e) {
>         LOG.error(e.getMessage(), e);
>         throw new HiveException(e);
>       }
>       return;
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to