[ https://issues.apache.org/jira/browse/HIVE-21234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767289#comment-16767289 ]
Hive QA commented on HIVE-21234: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12958545/HIVE-21234.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 145 failed/errored test(s), 15786 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constprog_type] (batchId=1) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_1] (batchId=96) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[interval_arithmetic] (batchId=51) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[metadata_only_queries] (batchId=34) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_external_time] (batchId=14) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_types_vectorization] (batchId=15) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_10] (batchId=24) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_13] (batchId=56) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_14] (batchId=42) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_15] (batchId=94) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_16] (batchId=88) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_17] (batchId=31) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_3] (batchId=83) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_7] (batchId=92) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_8] (batchId=15) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_vectorization_9] (batchId=32) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[schema_evol_par_vec_table_dictionary_encoding] (batchId=28) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[schema_evol_par_vec_table_non_dictionary_encoding] (batchId=54) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[temp_table_windowing_expressions] (batchId=69) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[timestamp_3] (batchId=41) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[typechangetest] (batchId=11) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_binary_join_groupby] (batchId=88) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_case_when_2] (batchId=58) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_data_types] (batchId=83) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_expressions] (batchId=57) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_interval_arithmetic] (batchId=4) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_parquet_types] (batchId=72) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_timestamp] (batchId=84) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_timestamp_funcs] (batchId=33) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_distinct] (batchId=61) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_expressions] (batchId=60) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_multipartitioning] (batchId=60) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_order_null] (batchId=59) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_rank] (batchId=57) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_windowspec] (batchId=19) org.apache.hadoop.hive.cli.TestMiniHiveKafkaCliDriver.testCliDriver[kafka_storage_handler] (batchId=275) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[parquet_types_vectorization] (batchId=153) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[acid_vectorization_original] (batchId=181) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_text] (batchId=179) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[metadata_only_queries] (batchId=167) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[parquet_predicate_pushdown] (batchId=166) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[parquet_types] (batchId=174) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_nonvec_part_all_primitive] (batchId=183) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_nonvec_part_all_primitive_llap_io] (batchId=183) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_vec_part_all_complex] (batchId=173) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_vec_part_all_complex_llap_io] (batchId=160) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_vec_part_all_primitive] (batchId=180) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_vec_part_all_primitive_llap_io] (batchId=165) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_nonvec_part_all_primitive] (batchId=173) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_nonvec_part_all_primitive_llap_io] (batchId=183) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part_all_complex] (batchId=168) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part_all_complex_llap_io] (batchId=159) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part_all_primitive] (batchId=176) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part_all_primitive_llap_io] (batchId=180) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part_llap_io] (batchId=183) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part_all_complex] (batchId=182) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part_all_complex_llap_io] (batchId=177) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part_all_primitive] (batchId=176) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part_all_primitive_llap_io] (batchId=167) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part_llap_io] (batchId=172) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_table_llap_io] (batchId=169) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_binary_join_groupby] (batchId=181) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_case_when_2] (batchId=174) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_data_types] (batchId=180) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_expressions] (batchId=174) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_fullouter_mapjoin_1_fast] (batchId=164) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_fullouter_mapjoin_1_optimized] (batchId=161) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_fullouter_mapjoin_1_optimized_passthru] (batchId=181) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_interval_arithmetic] (batchId=160) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_expressions] (batchId=181) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_multipartitioning] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_order_null] (batchId=169) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_rank] (batchId=175) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_windowspec] (batchId=168) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_parquet_types] (batchId=177) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_timestamp] (batchId=180) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_timestamp_funcs] (batchId=167) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[windowing_windowspec2] (batchId=175) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[acid_vectorization_original_tez] (batchId=110) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[metadata_only_queries] (batchId=126) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_10] (batchId=121) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_13] (batchId=135) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_14] (batchId=128) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_15] (batchId=151) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_16] (batchId=149) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_17] (batchId=124) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_3] (batchId=147) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_7] (batchId=150) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_8] (batchId=117) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[parquet_vectorization_9] (batchId=125) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[timestamp_1] (batchId=123) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[timestamp_2] (batchId=111) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[timestamp_3] (batchId=128) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[timestamp_udf] (batchId=147) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vector_data_types] (batchId=146) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_timestamp_funcs] (batchId=125) org.apache.hadoop.hive.ql.exec.vector.TestVectorRowObject.testVectorRowObject (batchId=312) org.apache.hadoop.hive.ql.exec.vector.TestVectorSerDeRow.testVectorBinarySortableDeserializeRow (batchId=316) org.apache.hadoop.hive.ql.exec.vector.TestVectorSerDeRow.testVectorBinarySortableSerializeRow (batchId=316) org.apache.hadoop.hive.ql.exec.vector.TestVectorSerDeRow.testVectorLazyBinaryDeserializeRow (batchId=316) org.apache.hadoop.hive.ql.exec.vector.TestVectorSerDeRow.testVectorLazyBinarySerializeRow (batchId=316) org.apache.hadoop.hive.ql.exec.vector.TestVectorSerDeRow.testVectorLazySimpleDeserializeRow (batchId=316) org.apache.hadoop.hive.ql.exec.vector.TestVectorSerDeRow.testVectorLazySimpleSerializeRow (batchId=316) org.apache.hadoop.hive.ql.exec.vector.aggregation.TestVectorAggregation.testMax (batchId=316) org.apache.hadoop.hive.ql.exec.vector.aggregation.TestVectorAggregation.testMin (batchId=316) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmetic.testDateInterval (batchId=316) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmetic.testTimestampDate (batchId=316) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmetic.testTimestampInterval (batchId=316) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorBetweenIn.testTimestamp (batchId=316) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testBigInt (batchId=316) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testDecimal (batchId=316) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testDouble (batchId=316) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testFloat (batchId=316) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testString (batchId=316) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCastStatement.testTimestamp (batchId=316) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorCoalesceElt.testCoalesce (batchId=313) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorDateExpressions.testVectorUDFDayOfMonth (batchId=313) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorDateExpressions.testVectorUDFMonth (batchId=313) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorDateExpressions.testVectorUDFUnixTimeStamp (batchId=313) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorDateExpressions.testVectorUDFWeekOfYear (batchId=313) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorDateExpressions.testVectorUDFYear (batchId=313) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorIfStatement.testTimestamp (batchId=313) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorIndex.testListIndex (batchId=314) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorIndex.testMapIndex (batchId=314) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorStructField.testStructField (batchId=316) org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorTypeCasts.testCastTimestampToDecimal (batchId=312) org.apache.hadoop.hive.ql.io.arrow.TestArrowColumnarBatchSerDe.testPrimitiveRandomTimestamp (batchId=297) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedColumnReader.testTimestamp (batchId=298) org.apache.hadoop.hive.ql.io.parquet.TestVectorizedDictionaryEncodingColumnReader.testTimestamp (batchId=297) org.apache.hadoop.hive.ql.io.parquet.serde.TestParquetTimestampUtils.testJulianDay (batchId=299) org.apache.hadoop.hive.ql.io.parquet.serde.TestParquetTimestampUtils.testNanos (batchId=299) org.apache.hadoop.hive.ql.io.parquet.serde.TestParquetTimestampUtils.testTimezone (batchId=299) org.apache.hadoop.hive.ql.io.parquet.serde.TestParquetTimestampUtils.testTimezoneValues (batchId=299) org.apache.hadoop.hive.ql.io.parquet.serde.TestParquetTimestampUtils.testTimezoneless (batchId=299) org.apache.hadoop.hive.ql.io.parquet.serde.TestParquetTimestampUtils.testTimezonelessValues (batchId=299) org.apache.hadoop.hive.serde2.io.TestTimestampWritableV2.testDecimalToTimestampCornerCases (batchId=331) org.apache.hadoop.hive.serde2.io.TestTimestampWritableV2.testDecimalToTimestampRandomly (batchId=331) org.apache.hadoop.hive.serde2.io.TestTimestampWritableV2.testTimestampsInFullRange (batchId=331) org.apache.hadoop.hive.serde2.io.TestTimestampWritableV2.testToFromDouble (batchId=331) org.apache.hadoop.hive.serde2.objectinspector.primitive.TestPrimitiveObjectInspectorUtils.testgetTimestampWithMillisecondsInt (batchId=332) org.apache.hadoop.hive.serde2.objectinspector.primitive.TestPrimitiveObjectInspectorUtils.testgetTimestampWithSecondsInt (batchId=332) org.apache.hive.hcatalog.pig.TestParquetHCatStorer.testWriteTimestamp (batchId=207) org.apache.hive.jdbc.TestJdbcWithMiniLlapArrow.testDataTypes (batchId=261) org.apache.hive.jdbc.TestJdbcWithMiniLlapRow.testDataTypes (batchId=261) org.apache.hive.jdbc.TestJdbcWithMiniLlapVectorArrow.testDataTypes (batchId=264) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16054/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16054/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16054/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 145 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12958545 - PreCommit-HIVE-Build > Enforce timestamp range > ----------------------- > > Key: HIVE-21234 > URL: https://issues.apache.org/jira/browse/HIVE-21234 > Project: Hive > Issue Type: Improvement > Components: Hive > Affects Versions: 3.1.0 > Reporter: Karen Coppage > Assignee: Karen Coppage > Priority: Major > Labels: TODOC, backwards-compatibility > Attachments: HIVE-21234.1.patch, HIVE-21234.2.patch > > > Our Wiki specifies a range for DATE, but not for TIMESTAMP (well, there's a > specified format (yyyy) but no explicitly specified range). [1] > TIMESTAMP used to have inner representation of java.sql.Timestamp which > couldn't handle timestamps outside of the range of years 0000-9999. (0000 > converted to 0001) > Since the inner representation was changed to LocalDateTime (HIVE-20007), > negative timestamps overflow because of a formatting error. > I propose simply disabling negative timestamps, and timestamps beyond year > 9999. No data is much better than bad data. > See [2] for more details. > [1] > https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types#LanguageManualTypes-TimestampstimestampTimestamps > [2] > https://docs.google.com/document/d/1y-GcyzzALXM2AJB3bFuyTAEq5fq6p41gu5eH1pF8I7o/edit?usp=sharing -- This message was sent by Atlassian JIRA (v7.6.3#76005)