[
https://issues.apache.org/jira/browse/HIVE-21234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779589#comment-16779589
]
Hive QA commented on HIVE-21234:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
47s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
49s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
41s{color} | {color:blue} common in master has 63 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
48s{color} | {color:blue} serde in master has 197 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
45s{color} | {color:blue} ql in master has 2251 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
41s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
13s{color} | {color:red} common: The patch generated 1 new + 7 unchanged - 0
fixed = 8 total (was 7) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
29s{color} | {color:red} serde: The patch generated 20 new + 1148 unchanged - 4
fixed = 1168 total (was 1152) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
9s{color} | {color:red} ql: The patch generated 45 new + 2903 unchanged - 11
fixed = 2948 total (was 2914) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
51s{color} | {color:red} common generated 2 new + 63 unchanged - 0 fixed = 65
total (was 63) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
1s{color} | {color:red} serde generated 3 new + 197 unchanged - 0 fixed = 200
total (was 197) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
57s{color} | {color:red} ql generated 1 new + 2250 unchanged - 1 fixed = 2251
total (was 2251) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 49s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:common |
| | org.apache.hadoop.hive.common.type.Date.toString() may return null
Returned at Date.java:Returned at Date.java:[line 89] |
| | org.apache.hadoop.hive.common.type.Timestamp.toString() may return null
Returned at Timestamp.java:Returned at Timestamp.java:[line 123] |
| FindBugs | module:serde |
| | org.apache.hadoop.hive.serde2.io.DateWritableV2.toString() may return
null Returned at DateWritableV2.java:Returned at DateWritableV2.java:[line
172] |
| | Dead store to b in
org.apache.hadoop.hive.serde2.io.TimestampWritableV2.convertTimestampToBytes(Timestamp,
byte[], int) At
TimestampWritableV2.java:org.apache.hadoop.hive.serde2.io.TimestampWritableV2.convertTimestampToBytes(Timestamp,
byte[], int) At TimestampWritableV2.java:[line 485] |
| | org.apache.hadoop.hive.serde2.io.TimestampWritableV2.toString() may
return null At TimestampWritableV2.java:At TimestampWritableV2.java:[line 385]
|
| FindBugs | module:ql |
| | Possible null pointer dereference of null in
org.apache.hadoop.hive.ql.udf.generic.GenericUDFToUnixTimeStamp.setValueFromTs(LongWritable,
Timestamp) Dereferenced at GenericUDFToUnixTimeStamp.java:null in
org.apache.hadoop.hive.ql.udf.generic.GenericUDFToUnixTimeStamp.setValueFromTs(LongWritable,
Timestamp) Dereferenced at GenericUDFToUnixTimeStamp.java:[line 178] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16272/dev-support/hive-personality.sh
|
| git revision | master / 66533e2 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16272/yetus/diff-checkstyle-common.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16272/yetus/diff-checkstyle-serde.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16272/yetus/diff-checkstyle-ql.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16272/yetus/new-findbugs-common.html
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16272/yetus/new-findbugs-serde.html
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16272/yetus/new-findbugs-ql.html
|
| modules | C: common serde ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16272/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Enforce timestamp range
> -----------------------
>
> Key: HIVE-21234
> URL: https://issues.apache.org/jira/browse/HIVE-21234
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Affects Versions: 3.1.0
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Major
> Labels: TODOC, backwards-compatibility
> Attachments: HIVE-21234.1.patch, HIVE-21234.2.patch,
> HIVE-21234.3.patch, HIVE-21234.4.patch
>
>
> Our Wiki specifies a range for DATE, but not for TIMESTAMP (well, there's a
> specified format (yyyy) but no explicitly specified range). [1]
> TIMESTAMP used to have inner representation of java.sql.Timestamp which
> couldn't handle timestamps outside of the range of years 0000-9999. (0000
> converted to 0001)
> Since the inner representation was changed to LocalDateTime (HIVE-20007),
> negative timestamps overflow because of a formatting error.
> I propose simply disabling negative timestamps, and timestamps beyond year
> 9999. No data is much better than bad data.
> See [2] for more details.
> [1]
> https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types#LanguageManualTypes-TimestampstimestampTimestamps
> [2]
> https://docs.google.com/document/d/1y-GcyzzALXM2AJB3bFuyTAEq5fq6p41gu5eH1pF8I7o/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
