[ https://issues.apache.org/jira/browse/HIVE-21815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860744#comment-16860744 ]
Hive QA commented on HIVE-21815: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12971421/HIVE-21815.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16044 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17517/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17517/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17517/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12971421 - PreCommit-HIVE-Build > Stats in ORC file are parsed twice > ---------------------------------- > > Key: HIVE-21815 > URL: https://issues.apache.org/jira/browse/HIVE-21815 > Project: Hive > Issue Type: Improvement > Components: ORC > Reporter: Gopal V > Assignee: Krisztian Kasa > Priority: Major > Attachments: HIVE-21815.1.patch, HIVE-21815.1.patch, > HIVE-21815.2.patch, orc-tail-getproto.png, tez-am-2x-protobuf.svg > > > ORC record reader unnecessarily parses stats twice > {code} > if (orcTail == null) { > Reader orcReader = OrcFile.createReader(file.getPath(), > OrcFile.readerOptions(context.conf) > .filesystem(fs) > .maxLength(AcidUtils.getLogicalLength(fs, file))); > orcTail = new OrcTail(orcReader.getFileTail(), > orcReader.getSerializedFileFooter(), > file.getModificationTime()); > if (context.cacheStripeDetails) { > context.footerCache.put(new FooterCacheKey(fsFileId, > file.getPath()), orcTail); > } > } > stripes = orcTail.getStripes(); > stripeStats = orcTail.getStripeStatistics(); > {code} > We go from Reader -> OrcTail -> StripeStatistics. > stripeStats is read out of the orcTail and is already read inside > orcReader.getStripeStatistics(). > !orc-tail-getproto.png! > [^tez-am-2x-protobuf.svg] -- This message was sent by Atlassian JIRA (v7.6.3#76005)