[ https://issues.apache.org/jira/browse/HIVE-21815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861101#comment-16861101 ]
Hive QA commented on HIVE-21815: -------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 18s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 12s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 43s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 8s{color} | {color:blue} ql in master has 2260 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 39s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17521/dev-support/hive-personality.sh | | git revision | master / 922b24e | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17521/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Stats in ORC file are parsed twice > ---------------------------------- > > Key: HIVE-21815 > URL: https://issues.apache.org/jira/browse/HIVE-21815 > Project: Hive > Issue Type: Improvement > Components: ORC > Reporter: Gopal V > Assignee: Krisztian Kasa > Priority: Major > Attachments: HIVE-21815.1.patch, HIVE-21815.1.patch, > HIVE-21815.2.patch, orc-tail-getproto.png, tez-am-2x-protobuf.svg > > > ORC record reader unnecessarily parses stats twice > {code} > if (orcTail == null) { > Reader orcReader = OrcFile.createReader(file.getPath(), > OrcFile.readerOptions(context.conf) > .filesystem(fs) > .maxLength(AcidUtils.getLogicalLength(fs, file))); > orcTail = new OrcTail(orcReader.getFileTail(), > orcReader.getSerializedFileFooter(), > file.getModificationTime()); > if (context.cacheStripeDetails) { > context.footerCache.put(new FooterCacheKey(fsFileId, > file.getPath()), orcTail); > } > } > stripes = orcTail.getStripes(); > stripeStats = orcTail.getStripeStatistics(); > {code} > We go from Reader -> OrcTail -> StripeStatistics. > stripeStats is read out of the orcTail and is already read inside > orcReader.getStripeStatistics(). > !orc-tail-getproto.png! > [^tez-am-2x-protobuf.svg] -- This message was sent by Atlassian JIRA (v7.6.3#76005)