[
https://issues.apache.org/jira/browse/HIVE-21959?focusedWorklogId=273230&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-273230
]
ASF GitHub Bot logged work on HIVE-21959:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/19 11:35
Start Date: 08/Jul/19 11:35
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #703: HIVE-21959
Clean up Concatenate and Msck DDL commands
URL: https://github.com/apache/hive/pull/703#discussion_r301041322
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/MsckDesc.java
##########
@@ -36,19 +34,16 @@
private static final long serialVersionUID = 1L;
private final String tableName;
- private final ArrayList<LinkedHashMap<String, String>> partitionsSpecs;
+ private final List<Map<String, String>> partitionsSpecs;
private final String resFile;
private final boolean repairPartitions;
private final boolean addPartitions;
private final boolean dropPartitions;
- public MsckDesc(String tableName, List<? extends Map<String, String>>
partitionSpecs, Path resFile,
+ public MsckDesc(String tableName, List<Map<String, String>> partitionsSpecs,
Path resFile,
boolean repairPartitions, boolean addPartitions, boolean dropPartitions)
{
this.tableName = tableName;
- this.partitionsSpecs = new ArrayList<LinkedHashMap<String,
String>>(partitionSpecs.size());
Review comment:
earlier; the approach was to make a new copy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 273230)
Time Spent: 20m (was: 10m)
> Clean up Concatenate and Msck DDL commands
> ------------------------------------------
>
> Key: HIVE-21959
> URL: https://issues.apache.org/jira/browse/HIVE-21959
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Affects Versions: 3.1.1
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available, refactor-ddl
> Fix For: 4.0.0
>
> Attachments: HIVE-21959.01.patch, HIVE-21959.02.patch,
> HIVE-21959.03.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Concatenate and Msck DDL use basic data structure implementations instead of
> their interfaces for variable declaration, like ArrayList instead of List,
> LinkedHashMap instead of Map, etc. This is due to a lot of similar issues in
> the code, which needs to be cleaned.
> Concatenate also had a non-immutable Desc class, that needs to be transformed
> into an immutable one. Concatenate operation code should be cut into smaller
> functions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
