[
https://issues.apache.org/jira/browse/HIVE-21959?focusedWorklogId=273566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-273566
]
ASF GitHub Bot logged work on HIVE-21959:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/19 22:32
Start Date: 08/Jul/19 22:32
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #703:
HIVE-21959 Clean up Concatenate and Msck DDL commands
URL: https://github.com/apache/hive/pull/703#discussion_r301327649
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java
##########
@@ -108,15 +108,16 @@ public int repair(MsckInfo msckInfo) {
boolean success = false;
long txnId = -1;
int ret = 0;
+ long partitionExpirySeconds = msckInfo.getPartitionExpirySeconds();
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 273566)
Time Spent: 1h (was: 50m)
> Clean up Concatenate and Msck DDL commands
> ------------------------------------------
>
> Key: HIVE-21959
> URL: https://issues.apache.org/jira/browse/HIVE-21959
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Affects Versions: 3.1.1
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available, refactor-ddl
> Fix For: 4.0.0
>
> Attachments: HIVE-21959.01.patch, HIVE-21959.02.patch,
> HIVE-21959.03.patch, HIVE-21959.04.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Concatenate and Msck DDL use basic data structure implementations instead of
> their interfaces for variable declaration, like ArrayList instead of List,
> LinkedHashMap instead of Map, etc. This is due to a lot of similar issues in
> the code, which needs to be cleaned.
> Concatenate also had a non-immutable Desc class, that needs to be transformed
> into an immutable one. Concatenate operation code should be cut into smaller
> functions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
