[ 
https://issues.apache.org/jira/browse/HIVE-22402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959875#comment-16959875
 ] 

Zoltan Haindrich commented on HIVE-22402:
-----------------------------------------

this is a little bit confusing; the summary says "deprecate Hive PerfLogger"; 
but the patch seems to adding another one; please describe what is the goal 
here...what features the new one will have/etc...
I don't totally follow what is an AbstractCachedPerfLogger - but I think you 
may use a marker interface instead of that...and why the api users should 
"extend" that instead of the interface?

I think more try-with-resources would be good - instead of manually coupled 
start/stop -s
and I think the "new" should cover the old in some way...I don't think we want 
PerfLogger and PerfTimer at the same time...

> Deprecate Hive PerfLogger
> -------------------------
>
>                 Key: HIVE-22402
>                 URL: https://issues.apache.org/jira/browse/HIVE-22402
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 4.0.0
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>         Attachments: HIVE-22402.1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to